From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 05/11] KVM: Expose a version 1 architectural PMU to guests Date: Tue, 14 Jun 2011 11:33:29 +0300 Message-ID: <4DF71CD9.8070908@redhat.com> References: <1307972106-2468-1-git-send-email-avi@redhat.com> <1307972106-2468-6-git-send-email-avi@redhat.com> <4DF6527D.7080003@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Arnaldo Carvalho de Melo To: David Ahern Return-path: Received: from mx1.redhat.com ([209.132.183.28]:22532 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755309Ab1FNIdu (ORCPT ); Tue, 14 Jun 2011 04:33:50 -0400 In-Reply-To: <4DF6527D.7080003@cisco.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/13/2011 09:10 PM, David Ahern wrote: > On 06/13/2011 07:35 AM, Avi Kivity wrote: > > diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c > > new file mode 100644 > > index 0000000..763e763 > > --- /dev/null > > +++ b/arch/x86/kvm/pmu.c > > @@ -0,0 +1,255 @@ > > +/* > > + * Kernel-based Virtual Machine -- Performane Monitoring Unit support > > + * > > + * Copyright 2011 Red Hat, Inc. and/or its affiliates. > > + * > > + * Authors: > > + * Avi Kivity > > + * > > + * This work is licensed under the terms of the GNU GPL, version 2. See > > + * the COPYING file in the top-level directory. > > + * > > + */ > > + > > +#include > > +#include > > +#include > > +#include "x86.h" > > +#include "pmu.h" > > If I remove the above line the patch set compiles cleanly. Is this an > old reference? kvm_pm* structs are defined in kvm_host.h. > Yes, thanks. I guess I have a stale pmu.h there. Will fix. -- error compiling committee.c: too many arguments to function