From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 07/12] kvm: Drop KVM_CAP build dependencies Date: Tue, 14 Jun 2011 13:19:59 +0200 Message-ID: <4DF743DF.9010904@siemens.com> References: <0392a4552957a340b66dbcb2031229a45527bce9.1307542247.git.jan.kiszka@siemens.com> <4DF7410E.9000505@siemens.com> <78B0A30A-9CF7-4C44-9FDC-1A353238C28B@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" To: Alexander Graf Return-path: Received: from thoth.sbs.de ([192.35.17.2]:22943 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754362Ab1FNLUH (ORCPT ); Tue, 14 Jun 2011 07:20:07 -0400 In-Reply-To: <78B0A30A-9CF7-4C44-9FDC-1A353238C28B@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-06-14 13:17, Alexander Graf wrote: > > On 14.06.2011, at 13:07, Jan Kiszka wrote: > >> On 2011-06-14 13:05, Alexander Graf wrote: >>> >>> On 08.06.2011, at 16:11, Jan Kiszka wrote: >>> >>>> No longer needed with accompanied kernel headers. We are only left with >>>> build dependencies that are controlled by kvm arch headers. >>> >>> This should completely rule out all CAPs right? IIRC, all CAPs are defined in generic code, so we don't get number overlaps. >> >> "We are only left with build dependencies that are controlled by kvm >> arch headers." E.g. KVM_CAP_VCPU_EVENTS. >> >>> >>>> >>>> CC: Alexander Graf >>>> Signed-off-by: Jan Kiszka >>>> --- >>>> kvm-all.c | 8 -------- >>>> 1 files changed, 0 insertions(+), 8 deletions(-) >>>> >>>> diff --git a/kvm-all.c b/kvm-all.c >>>> index 4a9910a..cbc2532 100644 >>>> --- a/kvm-all.c >>>> +++ b/kvm-all.c >>>> @@ -757,21 +757,17 @@ int kvm_init(void) >>>> s->coalesced_mmio = kvm_check_extension(s, KVM_CAP_COALESCED_MMIO); >>>> >>>> s->broken_set_mem_region = 1; >>>> -#ifdef KVM_CAP_JOIN_MEMORY_REGIONS_WORKS >>>> ret = kvm_check_extension(s, KVM_CAP_JOIN_MEMORY_REGIONS_WORKS); >>>> if (ret > 0) { >>>> s->broken_set_mem_region = 0; >>>> } >>>> -#endif >>>> >>>> #ifdef KVM_CAP_VCPU_EVENTS >>> >>> ... which leaves the question why this one is still here :). >> >> See above (does PPC support it?). > > Well, regardless of support, the #ifdef shouldn't be required, right? > > include/linux/kvm.h:518:#define KVM_CAP_VCPU_EVENTS 41 > > ... as long as there's a runtime check :) Are all types and dependent constants available? Maybe it is the case here, but you cannot generally assume this if a CAP is per-arch. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux