From: Avi Kivity <avi@redhat.com>
To: "Yang, Wei" <wei.y.yang@intel.com>
Cc: kvm@vger.kernel.org, the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [PATCH 0/3] Enable RDWRGSFS feature support for KVM
Date: Tue, 14 Jun 2011 15:40:56 +0300 [thread overview]
Message-ID: <4DF756D8.6000405@redhat.com> (raw)
In-Reply-To: <4DF75480.2040900@redhat.com>
On 06/14/2011 03:30 PM, Avi Kivity wrote:
> On 06/14/2011 03:10 PM, Yang, Wei wrote:
>> This patch enalbes RDWRGSFS feature to KVM guests.
>>
>> Write/read FS/GS base instructions enable user level code
>> to read/write FS& GS segment base registers for thread
>> local storage.
>>
>
> Patches look good, but something appears missing - usually when an
> instruction is enabled by a cr4 bit, there is an additional cpuid bit
> that gets turned on, so userspace can tell if it is safe to use the
> instruction. Is it not the case here?
I found it in the AVX2 spec, and it appears there is no such bit. How
is userspace supposed to know if it can use the instruction or not?
Anyway, patches applied, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-06-14 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 12:10 [PATCH 0/3] Enable RDWRGSFS feature support for KVM Yang, Wei
2011-06-14 12:10 ` [PATCH 1/3] Remove RDWRGSFS bit from CR4_RESERVED_BITS Yang, Wei
2011-06-14 12:10 ` [PATCH 2/3] Add RDWRGSFS support when setting CR4 Yang, Wei
2011-06-14 12:10 ` [PATCH 3/3] Expose RDWRGSFS bit to KVM guests Yang, Wei
2011-06-14 12:30 ` [PATCH 0/3] Enable RDWRGSFS feature support for KVM Avi Kivity
2011-06-14 12:40 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF756D8.6000405@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=wei.y.yang@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox