From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Krumme <Chris.Krumme@windriver.com>
Subject: Re: [Qemu-devel] [PATCH 06/10] kvm: remove unused variables
Date: Wed, 15 Jun 2011 07:44:48 -0500
Message-ID: <4DF8A940.40006@windriver.com>
References: <cover.1308072799.git.mst@redhat.com> <b8c61957187f86291291abfaed88f44ac8d41b95.1308072799.git.mst@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	<kvm@vger.kernel.org>, Jan Kiszka <jan.kiszka@siemens.com>,
	Riku Voipio <riku.voipio@iki.fi>,
	Christoph Hellwig <hch@lst.de>,
	Blue Swirl <blauwirbel@gmail.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Isaku Yamahata <yamahata@valinux.co.jp>,
	Paul Brook <paul@codesourcery.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Avi Kivity <avi@redhat.com>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Richard Henderson <rth@twiddle.net>
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail.windriver.com ([147.11.1.11]:61183 "EHLO
	mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753326Ab1FOMsI (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 15 Jun 2011 08:48:08 -0400
In-Reply-To: <b8c61957187f86291291abfaed88f44ac8d41b95.1308072799.git.mst@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 06/14/2011 12:36 PM, Michael S. Tsirkin wrote:
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
> ---
>   hw/virtio-pci.h   |    8 +++++---
>   target-i386/kvm.c |    3 +--
>   2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/hw/virtio-pci.h b/hw/virtio-pci.h
> index a4b5fd3..b518917 100644
> --- a/hw/virtio-pci.h
> +++ b/hw/virtio-pci.h
> @@ -37,7 +37,9 @@ typedef struct {
>       bool ioeventfd_started;
>   } VirtIOPCIProxy;
>
> -extern void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev,
> -                            uint16_t vendor, uint16_t device,
> -                            uint16_t class_code, uint8_t pif);
> +void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev);

Hello MST,

The above change shows why we should be including a header, rather than 
having private prototypes (w/bitrot).

> +
> +/* Virtio ABI version, if we increment this, we break the guest driver. */
> +#define VIRTIO_PCI_ABI_VERSION          0
> +

This change seems unrelated.

Thanks

Chris

>   #endif
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index faedc6c..58a70bc 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -970,7 +970,7 @@ static int kvm_get_xsave(CPUState *env)
>   #ifdef KVM_CAP_XSAVE
>       struct kvm_xsave* xsave;
>       int ret, i;
> -    uint16_t cwd, swd, twd, fop;
> +    uint16_t cwd, swd, twd;
>
>       if (!kvm_has_xsave()) {
>           return kvm_get_fpu(env);
> @@ -986,7 +986,6 @@ static int kvm_get_xsave(CPUState *env)
>       cwd = (uint16_t)xsave->region[0];
>       swd = (uint16_t)(xsave->region[0]>>  16);
>       twd = (uint16_t)xsave->region[1];
> -    fop = (uint16_t)(xsave->region[1]>>  16);
>       env->fpstt = (swd>>  11)&  7;
>       env->fpus = swd;
>       env->fpuc = cwd;