Re: [PATCH] support piix PAM registers in KVM

Marcelo Tosatti
2010-09-22T20:50:44Z

On Tue, Sep 21, 2010 at 02:31:42PM +0200, Gleb Natapov wrote:
> Without this BIOS fails to remap 0xf0000 memory from ROM to RAM so writes
> to F-segment modify ROM content instead of memory copy. Since QEMU does
> not reloads ROMs during reset on next boot modified copy of BIOS is used.
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 933ad86..0bf435d 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -99,10 +99,6 @@ static void i440fx_update_memory_mappings(PCII440FXState *d)
> int i, r;
> uint32_t smram, addr;
>
> - if (kvm_enabled()) {
> - /* FIXME: Support remappings and protection changes. */
> - return;
> - }
> update_pam(d, 0xf0000, 0x100000, (d->dev.config[I440FX_PAM] >> 4) & 3);
> for(i = 0; i < 12; i++) {
> r = (d->dev.config[(i >> 1) + (I440FX_PAM + 1)] >> ((i & 1) * 4)) & 3;
> --
> Gleb.

Ugh, we should support ro slots to avoid such kind of problems...

Applied, thanks.