From mboxrd@z Thu Jan  1 00:00:00 1970
From: Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 10/10] linux-user: remove unused variables
Date: Wed, 15 Jun 2011 07:32:50 -0700
Message-ID: <4DF8C292.7080900@twiddle.net>
References: <cover.1308072799.git.mst@redhat.com> <fd304ad8f556300ce3ee29bf615a5e5a0a28eb6a.1308072799.git.mst@redhat.com> <95538E92-0A9C-4464-BFE6-F44E528AB6FA@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: "Michael S.Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org,
	Paul Brook <paul@codesourcery.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Riku Voipio <riku.voipio@iki.fi>, Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Blue Swirl <blauwirbel@gmail.com>,
	Stefan Weil <weil@mail.berlios.de>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Christoph Hellwig <hch@lst.de>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Isaku Yamahata <yamahata@valinux.co.jp>, kvm@vger.kernel.org
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-yi0-f46.google.com ([209.85.218.46]:42455 "EHLO
	mail-yi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754790Ab1FOOc4 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 15 Jun 2011 10:32:56 -0400
Received: by yia27 with SMTP id 27so260408yia.19
        for <kvm@vger.kernel.org>; Wed, 15 Jun 2011 07:32:55 -0700 (PDT)
In-Reply-To: <95538E92-0A9C-4464-BFE6-F44E528AB6FA@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 06/15/2011 01:35 AM, Alexander Graf wrote:
>> -                abi_ulong arg5 = 0, arg6 = 0, arg7 = 0, arg8 = 0;
>> +                abi_ulong arg5 = 0, arg6 = 0;
>>
>>                 nb_args = mips_syscall_args[syscall_num];
>>                 sp_reg = env->active_tc.gpr[29];
>>                 switch (nb_args) {
>>                 /* these arguments are taken from the stack */
>>                 /* FIXME - what to do if get_user() fails? */
>> -                case 8: get_user_ual(arg8, sp_reg + 28);
>> -                case 7: get_user_ual(arg7, sp_reg + 24);
>> +                case 8: /* get_user_ual(arg8, sp_reg + 28); */
>> +                case 7: /* get_user_ual(arg7, sp_reg + 24); */
> 
> I'd prefer to see these and the respective variable definitions #if
> 0'd with a comment, stating that they're currently unused.

I'd prefer not to see if 0 code.  Better, I think, to mark the
variables as __attribute__((unused)) with that same comment.

>> @@ -7058,18 +7056,14 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
>>     case TARGET_NR_osf_sigprocmask:
>>         {
>>             abi_ulong mask;
>> -            int how = arg1;
>>             sigset_t set, oldset;
>>
>>             switch(arg1) {
>>             case TARGET_SIG_BLOCK:
>> -                how = SIG_BLOCK;
>>                 break;
>>             case TARGET_SIG_UNBLOCK:
>> -                how = SIG_UNBLOCK;
>>                 break;
>>             case TARGET_SIG_SETMASK:
>> -                how = SIG_SETMASK;
> 
> why go through the effort of setting "how" and then not using it? I'm
> pretty sure this is a bug as well. A few lines down is the following
> code:
> 
>    sigprocmask(arg1, &set, &oldset);
> 
> which in TARGET_NR_sigprocmask would be:
> 
>   ret = get_errno(sigprocmask(how, &set, &oldset));
> 
> So we end up sending guest masks to the host. Richard, this is Alpha
> specific code. Mind to double-check?

I remember fixing this before.  Perhaps it was in a patch tree that 
never got pulled...


r~