From: Jan Kiszka <jan.kiszka@siemens.com>
To: Alexandre Raymond <cerbere@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sasha Levin <levinsasha928@gmail.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [RFC][PATCH] Register Linux dyntick timer as per-thread signal
Date: Fri, 17 Jun 2011 11:25:23 +0200 [thread overview]
Message-ID: <4DFB1D83.3020606@siemens.com> (raw)
In-Reply-To: <BANLkTinarwP=AwG_KFm0B3moFYbQOQ2SbQ@mail.gmail.com>
On 2011-06-16 17:24, Alexandre Raymond wrote:
> Hi Jan,
>
> On Thu, Jun 16, 2011 at 5:31 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> Ingo Molnar pointed out that sending the timer signal to the whole
>> process, just blocking it everywhere, is suboptimal with an increasing
>> number of threads. QEMU is using this pattern so far.
>
> I am not familiar with this code, but don't you already need to block
> SIGALRM properly in all threads for OSes != Linux ? If so, isn't this
> patch redundant?
Yes, we still need to block for the sake of non-Linux UNIX or
pre-signalfd Linux. That blocking becomes in fact redundant in the
signalfd case, but that's both harmless and not worth optimizing. The
key is that per-thread signals do not care about other threads having
them blocked or not, they only deal with the target thread.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-06-17 9:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 9:31 [RFC][PATCH] Register Linux dyntick timer as per-thread signal Jan Kiszka
2011-06-16 10:26 ` Ingo Molnar
2011-06-16 14:39 ` [Qemu-devel] " Richard Henderson
2011-06-16 15:24 ` Alexandre Raymond
2011-06-17 9:25 ` Jan Kiszka [this message]
2011-06-17 9:25 ` [PATCH v2] " Jan Kiszka
2011-06-17 18:06 ` [Qemu-devel] " Richard Henderson
2011-07-23 16:52 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFB1D83.3020606@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=aliguori@us.ibm.com \
--cc=cerbere@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox