From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Rik van Riel <riel@redhat.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Peter Zijlstra <peterz@infradead.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Eric B Munson <emunson@mgebm.net>
Subject: Re: [PATCH 3/7] KVM-HV: KVM Steal time implementation
Date: Sun, 19 Jun 2011 16:02:22 +0300 [thread overview]
Message-ID: <4DFDF35E.8030504@redhat.com> (raw)
In-Reply-To: <20110619125956.GV491@redhat.com>
On 06/19/2011 03:59 PM, Gleb Natapov wrote:
> On Sun, Jun 19, 2011 at 03:35:58PM +0300, Avi Kivity wrote:
> > On 06/15/2011 12:09 PM, Gleb Natapov wrote:
> > >>
> > >> Actually, I'd expect most read/writes to benefit from caching, no?
> > >> So why don't we just rename kvm_write_guest_cached() to
> > >> kvm_write_guest(), and the few places - if any - that need to force
> > >> transversing of the gfn mappings, get renamed to
> > >> kvm_write_guest_uncached ?
> > >>
> > >Good idea. I do not see any places where kvm_write_guest_uncached is
> > >needed from a brief look. Avi?
> > >
> >
> > kvm_write_guest_cached() needs something to supply the cache, and
> > needs recurring writes to the same location. Neither of these are
> > common (for example, instruction emulation doesn't have either).
> >
> Correct. Missed that. So what about changing steal time to use
> kvm_write_guest_cached()?
Makes sense, definitely. Want to post read_guest_cached() as well?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-06-19 13:02 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 23:31 [PATCH 0/7] KVM steal time implementation Glauber Costa
2011-06-13 23:31 ` [PATCH 1/7] KVM-HDR Add constant to represent KVM MSRs enabled bit Glauber Costa
2011-06-14 0:59 ` Rik van Riel
2011-06-14 1:18 ` Eric B Munson
2011-06-13 23:31 ` [PATCH 2/7] KVM-HDR: KVM Steal time implementation Glauber Costa
2011-06-14 1:19 ` Eric B Munson
2011-06-14 1:33 ` Rik van Riel
2011-06-13 23:31 ` [PATCH 3/7] KVM-HV: " Glauber Costa
2011-06-14 1:20 ` Eric B Munson
2011-06-14 7:45 ` Gleb Natapov
2011-06-15 1:01 ` Glauber Costa
2011-06-15 3:09 ` Glauber Costa
2011-06-15 9:09 ` Gleb Natapov
2011-06-16 3:31 ` Glauber Costa
2011-06-16 11:27 ` Gleb Natapov
2011-06-16 12:11 ` Glauber Costa
2011-06-16 12:21 ` Gleb Natapov
2011-06-16 12:24 ` Glauber Costa
2011-06-19 12:35 ` Avi Kivity
2011-06-19 12:59 ` Gleb Natapov
2011-06-19 13:02 ` Avi Kivity [this message]
2011-06-20 7:21 ` Gleb Natapov
2011-06-20 8:02 ` Avi Kivity
2011-06-20 12:42 ` Glauber Costa
2011-06-20 13:38 ` Gleb Natapov
2011-06-14 12:20 ` Rik van Riel
2011-06-13 23:31 ` [PATCH 4/7] KVM-GST: Add a pv_ops stub for steal time Glauber Costa
2011-06-14 1:20 ` Eric B Munson
2011-06-14 13:23 ` Rik van Riel
2011-06-13 23:31 ` [PATCH 5/7] KVM-GST: KVM Steal time accounting Glauber Costa
2011-06-14 1:21 ` Eric B Munson
2011-06-14 10:10 ` Peter Zijlstra
2011-06-15 1:08 ` Glauber Costa
2011-06-15 9:28 ` Peter Zijlstra
2011-06-13 23:31 ` [PATCH 6/7] KVM-GST: adjust scheduler cpu power Glauber Costa
2011-06-14 1:21 ` Eric B Munson
2011-06-14 2:47 ` Asias He
2011-06-14 10:42 ` Peter Zijlstra
2011-06-15 1:26 ` Glauber Costa
2011-06-20 14:41 ` Peter Zijlstra
2011-06-13 23:31 ` [PATCH 7/7] KVM-GST: KVM Steal time registration Glauber Costa
2011-06-14 1:21 ` Eric B Munson
2011-06-14 8:06 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFDF35E.8030504@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=emunson@mgebm.net \
--cc=gleb@redhat.com \
--cc=glommer@redhat.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox