From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Add compat ioctl for KVM_SET_SIGNAL_MASK Date: Sun, 19 Jun 2011 16:37:08 +0300 Message-ID: <4DFDFB84.3090903@redhat.com> References: <1307493937-7797-1-git-send-email-agraf@suse.de> <4DF0BB84.7090405@redhat.com> <4DF0ED75.3040500@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Graf , KVM list , kvm-ppc@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59445 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754001Ab1FSNhO (ORCPT ); Sun, 19 Jun 2011 09:37:14 -0400 In-Reply-To: <4DF0ED75.3040500@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/09/2011 06:57 PM, Paolo Bonzini wrote: > > -------------------------- 8< ----------------------------- > From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 > From: Paolo Bonzini > Date: Thu, 9 Jun 2011 17:48:50 +0200 > Subject: [PATCH] KVM: fix documentation for KVM_SET_SIGNAL_MASK > > The signal mask passed to KVM_SET_SIGNAL_MASK needs to be ABI-compatible > with sigprocmask, so that functions operating on sigset_t can be used > with it. Referring to the signal mask as an array of bytes is incorrect > on big endian systems, fix it. > > Signed-off-by: Paolo Bonzini > --- > Documentation/kvm/api.txt | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/kvm/api.txt b/Documentation/kvm/api.txt > index 9bef4e4..ec15972 100644 > --- a/Documentation/kvm/api.txt > +++ b/Documentation/kvm/api.txt > @@ -464,8 +464,8 @@ signal mask. > > /* for KVM_SET_SIGNAL_MASK */ > struct kvm_signal_mask { > - __u32 len; > - __u8 sigset[0]; > + __u32 len; > + unsigned long sigset[0]; > }; But that doesn't match the definition in kvm.h. If someone sets kvm_signal_mask::sigset[3], they'll get different answers if they look at the documentation or the code. So it needs to be documented in English, not C. (and not whitespace-damaged, either) -- error compiling committee.c: too many arguments to function