From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: MMU: make kvm_mmu_reset_context() flush the guest TLB Date: Tue, 21 Jun 2011 17:29:59 +0300 Message-ID: <4E00AAE7.2090004@redhat.com> References: <1307892300-3288-1-git-send-email-avi@redhat.com> <20110620183234.GB19717@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63225 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756662Ab1FUOaC (ORCPT ); Tue, 21 Jun 2011 10:30:02 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5LEU2rP028522 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Jun 2011 10:30:02 -0400 In-Reply-To: <20110620183234.GB19717@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 06/20/2011 09:32 PM, Marcelo Tosatti wrote: > On Sun, Jun 12, 2011 at 06:25:00PM +0300, Avi Kivity wrote: > > kvm_set_cr0() and kvm_set_cr4(), and possible other functions, > > assume that kvm_mmu_reset_context() flushes the guest TLB. However, > > it does not. > > TLB flush should be done lazily during guest entry, in > kvm_mmu_load(). Don't see why this patch is needed. You're right. It should be reverted. -- error compiling committee.c: too many arguments to function