From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>,
kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp,
mingo@elte.hu
Subject: Re: [PATCH v3 1/3] KVM: MMU: Clean up the error handling of walk_addr_generic()
Date: Wed, 22 Jun 2011 20:05:31 +0300 [thread overview]
Message-ID: <4E0220DB.1010504@redhat.com> (raw)
In-Reply-To: <20110622164658.GA23842@amt.cnet>
On 06/22/2011 07:46 PM, Marcelo Tosatti wrote:
> > if (unlikely(!is_present_gpte(pte))) {
> > - present = false;
> > - break;
> > + errcode |= PFERR_PRESENT_MASK;
> > + goto error;
> > }
>
> Assignment of PFERR_PRESENT_MASK is inverted.
>
Note: kvm-unit-tests.git/x86/access.flat would have caught this.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-06-22 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 14:29 [PATCH v3 1/3] KVM: MMU: Clean up the error handling of walk_addr_generic() Takuya Yoshikawa
2011-06-20 14:31 ` [PATCH v3 2/3] KVM: MMU: Rename the walk label in walk_addr_generic() Takuya Yoshikawa
2011-06-20 14:34 ` [PATCH v3 3/3] KVM: MMU: Introduce is_last_gpte() to clean up walk_addr_generic() Takuya Yoshikawa
2011-06-22 16:46 ` [PATCH v3 1/3] KVM: MMU: Clean up the error handling of walk_addr_generic() Marcelo Tosatti
2011-06-22 17:05 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0220DB.1010504@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox