From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v3 1/3] KVM: MMU: Clean up the error handling of walk_addr_generic()
Date: Wed, 22 Jun 2011 20:05:31 +0300
Message-ID: <4E0220DB.1010504@redhat.com>
References: <20110620232947.83d016d3.takuya.yoshikawa@gmail.com> <20110622164658.GA23842@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>, kvm@vger.kernel.org,
	yoshikawa.takuya@oss.ntt.co.jp, mingo@elte.hu
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:59825 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757493Ab1FVRFo (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 22 Jun 2011 13:05:44 -0400
In-Reply-To: <20110622164658.GA23842@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 06/22/2011 07:46 PM, Marcelo Tosatti wrote:
> >   		if (unlikely(!is_present_gpte(pte))) {
> >  -			present = false;
> >  -			break;
> >  +			errcode |= PFERR_PRESENT_MASK;
> >  +			goto error;
> >   		}
>
> Assignment of PFERR_PRESENT_MASK is inverted.
>

Note: kvm-unit-tests.git/x86/access.flat would have caught this.


-- 
error compiling committee.c: too many arguments to function