Re: [PATCH v2 01/12] Add kernel header update script

Peter Maydell
2011-06-08T15:57:53Z

On 8 June 2011 16:06, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> +    if [ $arch == x86 ]; then

This should be a single '=' -- '==' is a bashism. The 'checkbashisms'
script (available in 'devscripts' package on debian and ubuntu)
catches this:

cam-vm-266:maverick:testing$ checkbashisms scripts/update-linux-headers.sh
possible bashism in
/home/petmay01/linaro/qemu-from-laptop/qemu/scripts/update-linux-headers.sh
line 39 (should be 'b = a'):
if [ $arch == x86 ]; then

Otherwise looks good.

-- PMM