From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH v2 21/22] KVM: MMU: mmio page fault support
Date: Fri, 24 Jun 2011 10:04:30 +0800
Message-ID: <4E03F0AE.8010700@cn.fujitsu.com>
References: <4E01FBC9.3020009@cn.fujitsu.com> <4E01FDE0.5080800@cn.fujitsu.com> <20110622215940.GA30064@amt.cnet> <4E02B0BE.7070003@cn.fujitsu.com> <20110623142134.GA12181@amt.cnet> <4E037E21.6010203@cn.fujitsu.com> <20110623201319.GA19483@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
	KVM <kvm@vger.kernel.org>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20110623201319.GA19483@amt.cnet>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 06/24/2011 04:13 AM, Marcelo Tosatti wrote:

>> No, not all no mmio spte is considered a genuine EPT misconfig, as the above
>> case, we can get !is_mmio_spte(), but it is not the genuine EPT misconfig
>> since it is caused by shadow page zapped
> 
> I mean it must be
> 
> if (is_mmio_spte(spte))
>     handle_mmio
> if (spte == spte_not_present) /* race, let CPU refault */
>     return
> handle EPT misconf
> 

The patch already did it as you say :p

if (is_mmio_spte(spte))
	return handle_mmio
if (spte_present(spte))
	return handle EPT misconfig

return page fault path /*I will fix it, let cpu refault instead*/