From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 12/13] pci-assign: Generic config space access management
Date: Tue, 28 Jun 2011 11:07:58 +0300
Message-ID: <4E098BDE.6020203@redhat.com>
References: <cover.1309198793.git.jan.kiszka@web.de>	 <007a0322c5a4af8a621375c4d2951eee01f2aa05.1309198794.git.jan.kiszka@web.de> <1309214919.2535.73.camel@x201>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Jan Kiszka <jan.kiszka@web.de>,
	Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:20253 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756424Ab1F1IID (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 28 Jun 2011 04:08:03 -0400
In-Reply-To: <1309214919.2535.73.camel@x201>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 06/28/2011 01:48 AM, Alex Williamson wrote:
>> +    memset(dev->direct_config_read + PCI_COMMAND, 0xff, 12);
> This is more efficient, but maybe we should memset each field for
> grep-ability.

Agree.  Or even

     pci_assign_set_direct_config(dev, register, start_bit, nr_bits);


-- 
error compiling committee.c: too many arguments to function