From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 12/13] pci-assign: Generic config space access management Date: Tue, 28 Jun 2011 10:19:53 +0200 Message-ID: <4E098EA9.5080302@web.de> References: <007a0322c5a4af8a621375c4d2951eee01f2aa05.1309198794.git.jan.kiszka@web.de> <1309214919.2535.73.camel@x201> <4E098BDE.6020203@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig83A80DB3ACF41309C43706C2" Cc: Alex Williamson , Marcelo Tosatti , kvm@vger.kernel.org, "Michael S. Tsirkin" To: Avi Kivity Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:55957 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757316Ab1F1IUO (ORCPT ); Tue, 28 Jun 2011 04:20:14 -0400 In-Reply-To: <4E098BDE.6020203@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig83A80DB3ACF41309C43706C2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-06-28 10:07, Avi Kivity wrote: > On 06/28/2011 01:48 AM, Alex Williamson wrote: >>> + memset(dev->direct_config_read + PCI_COMMAND, 0xff, 12); >> This is more efficient, but maybe we should memset each field for >> grep-ability. >=20 > Agree. Or even >=20 > pci_assign_set_direct_config(dev, register, start_bit, nr_bits); Given that pci_regs.h defines masks and not bits, working with |=3D and &= =3D is more handy. Jan --------------enig83A80DB3ACF41309C43706C2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk4JjqkACgkQitSsb3rl5xTkVACgrRwvwf8gt51jKAVkPHkzLfs5 QjcAn3XktnrZk0u5jRY5Pz0TzDnOGoy6 =HiyG -----END PGP SIGNATURE----- --------------enig83A80DB3ACF41309C43706C2--