From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC v2 01/20] Hierarchical memory region API Date: Tue, 28 Jun 2011 15:09:38 +0300 Message-ID: <4E09C482.6050508@redhat.com> References: <1309180927-19003-1-git-send-email-avi@redhat.com> <1309180927-19003-2-git-send-email-avi@redhat.com> <20110628100343.GA21866@redhat.com> <4E09ACD2.9070907@siemens.com> <4E09C0B2.3030101@redhat.com> <4E09C3F6.8010702@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51536 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756271Ab1F1MJp (ORCPT ); Tue, 28 Jun 2011 08:09:45 -0400 In-Reply-To: <4E09C3F6.8010702@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/28/2011 03:07 PM, Jan Kiszka wrote: > > > > The point is that different buses have different widths. > > target_phys_addr_t matches just one bus in the system. It needs to be > > the maximum size of all buses present to be useful. > > Then we need a type for that. Or we need to demand that > target_phys_addr_t is defined large enough to support all buses that the > particular arch wants to address. Hardcoding 64 bit or anything is not > appropriate for a generic subsystem. Okay, let's make t_p_a_t max(bus size in system). Do we have 32-bit targets that don't support pci (I guess, pc-isa with cpu < ppro?). Do we want to support a 32-bit variant of pci? It certainly existed at some point. -- error compiling committee.c: too many arguments to function