From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 04/13] qemu-kvm: Remove eventfd compat header Date: Tue, 28 Jun 2011 14:40:24 +0200 Message-ID: <4E09CBB8.6090601@web.de> References: <20110628110908.GB5661@redhat.com> <4E09B6D8.1010406@web.de> <20110628120733.GB6395@redhat.com> <4E09C4EB.1000409@web.de> <20110628121719.GA6543@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig579BCC881636C6D9A474774D" Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org, Alex Williamson To: "Michael S. Tsirkin" Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:48802 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757473Ab1F1Mk0 (ORCPT ); Tue, 28 Jun 2011 08:40:26 -0400 In-Reply-To: <20110628121719.GA6543@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig579BCC881636C6D9A474774D Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-06-28 14:17, Michael S. Tsirkin wrote: > On Tue, Jun 28, 2011 at 02:11:23PM +0200, Jan Kiszka wrote: >> On 2011-06-28 14:07, Michael S. Tsirkin wrote: >>> On Tue, Jun 28, 2011 at 01:11:20PM +0200, Jan Kiszka wrote: >>>> On 2011-06-28 13:09, Michael S. Tsirkin wrote: >>>>> On Mon, Jun 27, 2011 at 08:19:47PM +0200, Jan Kiszka wrote: >>>>>> From: Jan Kiszka >>>>>> >>>>>> No longer used. >>>>>> >>>>>> Signed-off-by: Jan Kiszka >>>>> >>>>> I think it's actually handy to build on old systems which have >>>>> a recent enough kernel but not the header. >>>>> Does it hurt much to keep it around? >>>> >>>> Unless I missed something, it's not part of any include search path.= So >>>> how can it help? >>>> >>> >>> We used to have compat last on search path. Is that no longer so? >> >> I did a grep for "compat" and found nothing suspicious in configure or= >> some makefile. So this file looked like dead bits to me. >> >> Jan >> >=20 > kvm_cflags=3D"$kvm_cflags -idirafter $source_path/compat" >=20 I see. That was dropped with the recent upstream merge (c13a890960). Please check what setup benefited from it, and then discuss if and how to reintroduce it via upstream. Jan --------------enig579BCC881636C6D9A474774D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk4Jy7gACgkQitSsb3rl5xSvLgCdEpaT4phR2+z8KHwbs/fZWe0z cK0AoLjOHBzV4v5O1JNxPjeVSsP4DDEb =Z/tq -----END PGP SIGNATURE----- --------------enig579BCC881636C6D9A474774D--