From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 19/22] KVM: MMU: lockless walking shadow page table Date: Wed, 29 Jun 2011 16:01:20 +0300 Message-ID: <4E0B2220.3050602@redhat.com> References: <4E01FBC9.3020009@cn.fujitsu.com> <4E01FDB4.60306@cn.fujitsu.com> <4E0AED86.2060908@redhat.com> <4E0B0997.4090206@cn.fujitsu.com> <4E0B09EA.1040304@redhat.com> <4E0B1191.6040100@cn.fujitsu.com> <4E0B182C.1090402@redhat.com> <4E0B1A75.4070705@cn.fujitsu.com> <4E0B1A4E.2030301@redhat.com> <4E0B1CE8.2060803@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , LKML , KVM To: Xiao Guangrong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:27726 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752009Ab1F2NBa (ORCPT ); Wed, 29 Jun 2011 09:01:30 -0400 In-Reply-To: <4E0B1CE8.2060803@cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/29/2011 03:39 PM, Xiao Guangrong wrote: > > > > Ok. Let's drop the two paths, and put this improvement on the TODO instead. > > > > Avi, i am sorry, i do not understand it clearly, it means keep the patch as the > original way and do the improvement after it merged? I mean, do all freeing using RCU and improve fork detection after merge. I don't like the extra complexity and the extra atomic ops. -- error compiling committee.c: too many arguments to function