From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Wolf <kwolf@redhat.com>
Subject: Re: [PATCH v2] block/raw-posix: Linux compat-ioctl warning workaround
Date: Thu, 30 Jun 2011 10:06:23 +0200
Message-ID: <4E0C2E7F.20904@redhat.com>
References: <20110629142517.GA4059@sig21.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>
To: Johannes Stezenbach <js@sig21.net>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:18099 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751499Ab1F3IDk (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 30 Jun 2011 04:03:40 -0400
In-Reply-To: <20110629142517.GA4059@sig21.net>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Am 29.06.2011 16:25, schrieb Johannes Stezenbach:
> On Linux x86_64 host with 32bit userspace, running
> qemu or even just "qemu-img create -f qcow2 some.img 1G"
> causes a kernel warning:
> 
> ioctl32(qemu-img:5296): Unknown cmd fd(3) cmd(00005326){t:'S';sz:0} arg(7fffffff) on some.img
> ioctl32(qemu-img:5296): Unknown cmd fd(3) cmd(801c0204){t:02;sz:28} arg(fff77350) on some.img
> 
> ioctl 00005326 is CDROM_DRIVE_STATUS,
> ioctl 801c0204 is FDGETPRM.
> 
> The warning appears because the Linux compat-ioctl handler for these
> ioctls only applies to block devices, while qemu also uses the ioctls on
> plain files.  Work around by calling fstat() the ensure the ioctls are
> only used on block devices.
> 
> Signed-off-by: Johannes Stezenbach <js@sig21.net>

Thanks, applied to the block branch.

Kevin