From: Asias He <asias.hejun@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Sasha Levin <levinsasha928@gmail.com>,
Prasad Joshi <prasadjoshi124@gmail.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v2 00/31] Implement user mode network for kvm tools
Date: Sat, 02 Jul 2011 11:49:21 +0800 [thread overview]
Message-ID: <4E0E9541.6040305@gmail.com> (raw)
In-Reply-To: <BANLkTikXfasRR8VqwEVrrwSCr+ftKjzQqA@mail.gmail.com>
On 07/02/2011 04:36 AM, Pekka Enberg wrote:
> On Fri, Jul 1, 2011 at 7:50 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>> On Fri, Jul 1, 2011 at 12:38 AM, Asias He <asias.hejun@gmail.com> wrote:
>>> On 06/30/2011 04:56 PM, Stefan Hajnoczi wrote:
>>>> On Thu, Jun 30, 2011 at 9:40 AM, Asias He <asias.hejun@gmail.com> wrote:
>>>>> uip stands for user mode {TCP,UDP}/IP. Currently, uip supports ARP, ICMP,
>>>>> IPV4, UDP, TCP. So any network protocols above UDP/TCP should work as well,
>>>>> e.g., HTTP, FTP, SSH, DNS.
>>>>
>>>> There is an existing uIP which might cause confusion, not sure if
>>>> you've seen it. First I thought you were using that :).
>>>
>>> I heard about uIP, but this patchset have nothing to do with uIP ;-)
>>>
>>> At first I was naming the user mode network as "UNET" which is User mode
>>> NETwork, however, I though uip looks better because it is shorter.
>>>
>>> Anyway, if uip do cause confusion. I'd like to change this naming.
>>
>> It's up to you but now is the right time to do it. Consider if
>> another program wants to reuse this code or if you ever want to make
>> it a library, it wouldn't help to have a confusing name.
>
> I don't care too much what we use as the namespace prefix but as a
> directory name tools/kvm/uip is pretty meaningless. I'd just move the
> code under tools/kvm/net to mirror what the kernel already has.
>
I have thought about putting user mode net code in tools/kvm/net.
However, we have net code in tools/kvm/virtio as well. Is this a problem
in terms of clean code organization?
And I think splitting the tap code in virtio/net.c into tools/kvm/net is
a good idea. Further, we can put macvtap related code into tools/kvm/net
as well.
--
Best Regards,
Asias He
next prev parent reply other threads:[~2011-07-02 3:51 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 8:40 [PATCH v2 00/31] Implement user mode network for kvm tools Asias He
2011-06-30 8:40 ` [PATCH v2 01/31] kvm tools: Introduce ethernet frame buffer system for uip Asias He
2011-06-30 8:40 ` [PATCH v2 02/31] kvm tools: Add ARP support " Asias He
2011-06-30 8:40 ` [PATCH v2 03/31] kvm tools: Add IPV4 " Asias He
2011-06-30 8:40 ` [PATCH v2 04/31] kvm tools: Implement IP checksum " Asias He
2011-06-30 8:40 ` [PATCH v2 05/31] kvm tools: Add ICMP support " Asias He
2011-06-30 8:40 ` [PATCH v2 06/31] kvm tools: Introduce struct uip_udp to present UDP package Asias He
2011-06-30 8:40 ` [PATCH v2 07/31] kvm tools: Introduce struct uip_pseudo_hdr to present UDP pseudo header Asias He
2011-06-30 8:40 ` [PATCH v2 08/31] kvm tools: Introduce struct uip_udp_socket Asias He
2011-06-30 8:40 ` [PATCH v2 09/31] kvm tools: Add two helpers to return UDP {header, total} length Asias He
2011-06-30 8:40 ` [PATCH v2 10/31] kvm tools: Add helper to return ethernet header length Asias He
2011-06-30 8:40 ` [PATCH v2 11/31] kvm tools: Implement uip_csum_udp() to calculate UDP checksum Asias He
2011-06-30 8:41 ` [PATCH v2 12/31] kvm tools: Add UDP support for uip Asias He
2011-07-01 11:46 ` Ingo Molnar
2011-07-01 15:24 ` Asias He
2011-06-30 8:41 ` [PATCH v2 13/31] kvm tools: Introduce struct uip_tcp to present TCP package Asias He
2011-06-30 8:41 ` [PATCH v2 14/31] kvm tools: Introduce struct uip_tcp_socket Asias He
2011-06-30 8:41 ` [PATCH v2 15/31] kvm tools: Add helpers to return TCP {header, total, payload} length Asias He
2011-06-30 8:41 ` [PATCH v2 16/31] kvm tools: Add helper to return start address of TCP payload Asias He
2011-06-30 8:41 ` [PATCH v2 17/31] kvm tools: Add helpers to test whether SYN or FIN bit is set Asias He
2011-06-30 8:41 ` [PATCH v2 18/31] kvm tools: Add helper to allocate and get TCP initial sequence number Asias He
2011-06-30 8:41 ` [PATCH v2 19/31] kvm tools: Implement uip_csum_tcp() to calculate TCP checksum Asias He
2011-06-30 8:41 ` [PATCH v2 20/31] kvm tools: Add TCP support for uip Asias He
2011-06-30 8:41 ` [PATCH v2 21/31] kvm tools: Introduce uip_init() " Asias He
2011-06-30 8:41 ` [PATCH v2 22/31] kvm tools: Introduce uip_tx() " Asias He
2011-06-30 8:41 ` [PATCH v2 23/31] kvm tools: Introduce uip_rx() " Asias He
2011-06-30 8:41 ` [PATCH v2 24/31] kvm tools: Add MACRO for user and tap mode for virtio net Asias He
2011-06-30 8:41 ` [PATCH v2 25/31] kvm tools: Reanme net_device to net_dev Asias He
2011-06-30 8:41 ` [PATCH v2 26/31] kvm tools: Introduce -net {user, tap, none} options for virtio net Asias He
2011-06-30 8:41 ` [PATCH v2 27/31] kvm tools: Change default guest MAC address to 00:15:15:15:15:15 Asias He
2011-06-30 8:41 ` [PATCH v2 28/31] kvm tools: Make virtio net work with user mode network Asias He
2011-06-30 8:41 ` [PATCH v2 29/31] kvm tools: Make default network mode to user mode Asias He
2011-06-30 8:41 ` [PATCH v2 30/31] kvm tools: Make default host ip address to 192.168.33.1 Asias He
2011-06-30 8:41 ` [PATCH v2 31/31] kvm tools: Introduce struct net_dev_operations Asias He
2011-06-30 8:56 ` [PATCH v2 00/31] Implement user mode network for kvm tools Stefan Hajnoczi
2011-06-30 15:32 ` Anthony Liguori
2011-07-01 0:18 ` Asias He
2011-07-01 11:53 ` Ingo Molnar
2011-07-01 13:46 ` Alexander Graf
2011-07-02 9:45 ` Pekka Enberg
2011-07-02 10:30 ` Ingo Molnar
2011-07-02 11:19 ` Alexander Graf
2011-07-02 11:27 ` Pekka Enberg
2011-07-02 12:31 ` Alexander Graf
2011-07-03 19:42 ` Ingo Molnar
2011-07-03 22:15 ` Alexander Graf
2011-07-04 9:11 ` Ingo Molnar
2011-07-04 9:30 ` Alexander Graf
2011-07-04 9:43 ` Ingo Molnar
2011-07-02 9:42 ` Pekka Enberg
2011-06-30 23:38 ` Asias He
2011-07-01 16:50 ` Stefan Hajnoczi
2011-07-01 20:36 ` Pekka Enberg
2011-07-02 3:49 ` Asias He [this message]
2011-07-02 9:02 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0E9541.6040305@gmail.com \
--to=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox