From mboxrd@z Thu Jan 1 00:00:00 1970 From: Asias He Subject: Re: [PATCH v2 00/31] Implement user mode network for kvm tools Date: Sat, 02 Jul 2011 11:49:21 +0800 Message-ID: <4E0E9541.6040305@gmail.com> References: <1309423279-3093-1-git-send-email-asias.hejun@gmail.com> <4E0D08E2.6080601@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Stefan Hajnoczi , Cyrill Gorcunov , Ingo Molnar , Sasha Levin , Prasad Joshi , kvm@vger.kernel.org To: Pekka Enberg Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:55290 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753126Ab1GBDvI (ORCPT ); Fri, 1 Jul 2011 23:51:08 -0400 Received: by iyb12 with SMTP id 12so3264105iyb.19 for ; Fri, 01 Jul 2011 20:51:08 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 07/02/2011 04:36 AM, Pekka Enberg wrote: > On Fri, Jul 1, 2011 at 7:50 PM, Stefan Hajnoczi wrote: >> On Fri, Jul 1, 2011 at 12:38 AM, Asias He wrote: >>> On 06/30/2011 04:56 PM, Stefan Hajnoczi wrote: >>>> On Thu, Jun 30, 2011 at 9:40 AM, Asias He wrote: >>>>> uip stands for user mode {TCP,UDP}/IP. Currently, uip supports ARP, ICMP, >>>>> IPV4, UDP, TCP. So any network protocols above UDP/TCP should work as well, >>>>> e.g., HTTP, FTP, SSH, DNS. >>>> >>>> There is an existing uIP which might cause confusion, not sure if >>>> you've seen it. First I thought you were using that :). >>> >>> I heard about uIP, but this patchset have nothing to do with uIP ;-) >>> >>> At first I was naming the user mode network as "UNET" which is User mode >>> NETwork, however, I though uip looks better because it is shorter. >>> >>> Anyway, if uip do cause confusion. I'd like to change this naming. >> >> It's up to you but now is the right time to do it. Consider if >> another program wants to reuse this code or if you ever want to make >> it a library, it wouldn't help to have a confusing name. > > I don't care too much what we use as the namespace prefix but as a > directory name tools/kvm/uip is pretty meaningless. I'd just move the > code under tools/kvm/net to mirror what the kernel already has. > I have thought about putting user mode net code in tools/kvm/net. However, we have net code in tools/kvm/virtio as well. Is this a problem in terms of clean code organization? And I think splitting the tap code in virtio/net.c into tools/kvm/net is a good idea. Further, we can put macvtap related code into tools/kvm/net as well. -- Best Regards, Asias He