From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Held <bheld@mgpi.de>
Subject: Re: [PATCH 04/13] qemu-kvm: Remove eventfd compat header
Date: Mon, 04 Jul 2011 14:13:36 +0200
Message-ID: <4E11AE70.5010208@mgpi.de>
References: <cover.1309198793.git.jan.kiszka@web.de> <b5e234a305d5baa9c177d78baed4754f2093ffbb.1309198794.git.jan.kiszka@web.de> <20110628110908.GB5661@redhat.com> <4E103A8B.70602@mgpi.de> <20110703095406.GA14862@redhat.com> <20110703095743.GB14862@redhat.com> <4E10B56F.2030305@mgpi.de> <20110704103744.GB11386@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Jan Kiszka <jan.kiszka@web.de>, Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org,
	Alex Williamson <alex.williamson@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from smtp.mgpi.de ([212.202.249.42]:57381 "EHLO smtp.mgpi.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752832Ab1GDMNi (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 4 Jul 2011 08:13:38 -0400
In-Reply-To: <20110704103744.GB11386@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Am 04.07.2011 12:37, schrieb Michael S. Tsirkin:
> On Sun, Jul 03, 2011 at 08:31:11PM +0200, Bernhard Held wrote:
>> SYS_eventfd2 is not defined on systems with old glibc. These numbers
>> are working for me, for 32 and 64 bit linux. What means
>> "__NR_eventfd2 does seem to exit"?
>
> My system seems to have a definition for the 64 bit
> _NR_eventfd2 in unistd.h.
> # grep __NR_eventfd2 /usr/include/*/*h
> /usr/include/asm-x86_64/unistd.h:#define __NR_eventfd2          290
> So I think we should use another name to avoid conflicts.

The definition of __NR_eventfd2 is embraced by

#ifndef __NR_eventfd2
   ...
#endif

which effectively avoids conflicts.

However the definition of the flags is unconditional, this is indeed buggy.

Best regards,
Bernhard