public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: "Yang, Wei Y" <wei.y.yang@intel.com>
Cc: "avi@redhat.com" <avi@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH kvm-unit-tests v2] access: check SMEP on prefetch pte path
Date: Tue, 05 Jul 2011 13:49:06 +0800	[thread overview]
Message-ID: <4E12A5D2.6050809@cn.fujitsu.com> (raw)
In-Reply-To: <5D8008F58939784290FAB48F5497519846ABFBD435@shsmsx502.ccr.corp.intel.com>

On 07/05/2011 09:24 AM, Yang, Wei Y wrote:
> 
> 
>> -----Original Message-----
>> From: kvm-owner@vger.kernel.org [mailto:kvm-owner@vger.kernel.org] On
>> Behalf Of Xiao Guangrong
>> Sent: Friday, July 01, 2011 4:06 PM
>> To: Yang, Wei Y
>> Cc: avi@redhat.com; kvm@vger.kernel.org
>> Subject: Re: [PATCH kvm-unit-tests v2] access: check SMEP on prefetch pte
>> path
>>
>> On 06/29/2011 06:24 PM, Yang, Wei wrote:
>>
>>> +
>>> +	/*
>>> +	 * Here we write the ro user page when
>>> +	 * cr0.wp=0, then we execute it and SMEP
>>> +	 * fault should happen.
>>> +	 */
>>> +	err_prepare_notwp = ac_test_do_access(&at1);
>>> +	if (!err_prepare_notwp) {
>>> +		printf("%s: SMEP prepare fail\n", __FUNCTION__);
>>> +		goto clean_up;
>>> +	}
>>> +
>>> +	at1.flags[AC_ACCESS_WRITE] = 0;
>>> +	at1.flags[AC_ACCESS_FETCH] = 1;
>>> +	ac_set_expected_status(&at1);
>>> +	err_smep_notwp = ac_test_do_access(&at1);
>>> +
>>
>> The address is accessed in the fist test, it is really "prefetch"-ed
>> in the second test?
> 
> What do you mean? Could you please elaborate it?

The title and the test case is "prefetch pte", is it really "prefetch" in
your test case? :-)

      reply	other threads:[~2011-07-05  5:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29 10:24 [PATCH kvm-unit-tests v2] access: check SMEP on prefetch pte path Yang, Wei
2011-07-01  8:05 ` Xiao Guangrong
2011-07-05  1:24   ` Yang, Wei Y
2011-07-05  5:49     ` Xiao Guangrong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E12A5D2.6050809@cn.fujitsu.com \
    --to=xiaoguangrong@cn.fujitsu.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=wei.y.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox