From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH kvm-unit-tests v2] access: check SMEP on prefetch pte path Date: Tue, 05 Jul 2011 13:49:06 +0800 Message-ID: <4E12A5D2.6050809@cn.fujitsu.com> References: <1309343079-4895-1-git-send-email-wei.y.yang@intel.com> <4E0D7FD3.8030206@cn.fujitsu.com> <5D8008F58939784290FAB48F5497519846ABFBD435@shsmsx502.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "avi@redhat.com" , "kvm@vger.kernel.org" To: "Yang, Wei Y" Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:53311 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753398Ab1GEFrR (ORCPT ); Tue, 5 Jul 2011 01:47:17 -0400 In-Reply-To: <5D8008F58939784290FAB48F5497519846ABFBD435@shsmsx502.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/05/2011 09:24 AM, Yang, Wei Y wrote: > > >> -----Original Message----- >> From: kvm-owner@vger.kernel.org [mailto:kvm-owner@vger.kernel.org] On >> Behalf Of Xiao Guangrong >> Sent: Friday, July 01, 2011 4:06 PM >> To: Yang, Wei Y >> Cc: avi@redhat.com; kvm@vger.kernel.org >> Subject: Re: [PATCH kvm-unit-tests v2] access: check SMEP on prefetch pte >> path >> >> On 06/29/2011 06:24 PM, Yang, Wei wrote: >> >>> + >>> + /* >>> + * Here we write the ro user page when >>> + * cr0.wp=0, then we execute it and SMEP >>> + * fault should happen. >>> + */ >>> + err_prepare_notwp = ac_test_do_access(&at1); >>> + if (!err_prepare_notwp) { >>> + printf("%s: SMEP prepare fail\n", __FUNCTION__); >>> + goto clean_up; >>> + } >>> + >>> + at1.flags[AC_ACCESS_WRITE] = 0; >>> + at1.flags[AC_ACCESS_FETCH] = 1; >>> + ac_set_expected_status(&at1); >>> + err_smep_notwp = ac_test_do_access(&at1); >>> + >> >> The address is accessed in the fist test, it is really "prefetch"-ed >> in the second test? > > What do you mean? Could you please elaborate it? The title and the test case is "prefetch pte", is it really "prefetch" in your test case? :-)