public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: qemu-devel@nongnu.org,
	Stefan Haynoczi <stefanha@linux.vnet.ibm.com>,
	kvm@vger.kernel.org, Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH 3/5] scsi-disk: Fixup debugging statement
Date: Tue, 05 Jul 2011 13:05:32 +0200	[thread overview]
Message-ID: <4E12EFFC.3020105@redhat.com> (raw)
In-Reply-To: <1309863815-28236-4-git-send-email-hare@suse.de>

On 07/05/2011 01:03 PM, Hannes Reinecke wrote:
> A debugging statement wasn't converted to the new interface.
>
> Signed-off-by: Hannes Reinecke<hare@suse.de>
> ---
>   hw/scsi-disk.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
> index c2a99fe..5804662 100644
> --- a/hw/scsi-disk.c
> +++ b/hw/scsi-disk.c
> @@ -1007,7 +1007,7 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t *buf)
>
>       command = buf[0];
>       outbuf = (uint8_t *)r->iov.iov_base;
> -    DPRINTF("Command: lun=%d tag=0x%x data=0x%02x", lun, tag, buf[0]);
> +    DPRINTF("Command: lun=%d tag=0x%x data=0x%02x", req->lun, req->tag, buf[0]);
>
>       if (scsi_req_parse(&r->req, buf) != 0) {
>           BADF("Unsupported command length, command %x\n", command);

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

  parent reply	other threads:[~2011-07-05 11:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 11:03 [PATCH 0/5][v6] Megasas HBA emulation Hannes Reinecke
2011-07-05 11:03 ` [PATCH 1/5] iov: Update parameter usage in iov_(to|from)_buf() Hannes Reinecke
2011-07-05 11:03   ` [PATCH 2/5] scsi: Add 'hba_private' to SCSIRequest Hannes Reinecke
2011-07-05 11:03     ` [PATCH 3/5] scsi-disk: Fixup debugging statement Hannes Reinecke
2011-07-05 11:03       ` [PATCH 4/5] scsi-disk: Mask out serial number EVPD Hannes Reinecke
2011-07-05 11:03         ` [PATCH 5/5] megasas: LSI Megaraid SAS emulation Hannes Reinecke
2011-07-05 13:06           ` Alexander Graf
2011-07-05 13:38           ` Alexander Graf
2011-07-05 13:59             ` Paolo Bonzini
2011-07-05 14:05               ` Alexander Graf
2011-07-05 15:21           ` [Qemu-devel] " Stefan Hajnoczi
2011-07-06  6:20             ` Hannes Reinecke
2011-07-06  8:39               ` Paolo Bonzini
2011-07-05 11:06         ` [PATCH 4/5] scsi-disk: Mask out serial number EVPD Paolo Bonzini
2011-07-05 11:05       ` Paolo Bonzini [this message]
2011-07-05 13:01 ` [PATCH 0/5][v6] Megasas HBA emulation Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E12EFFC.3020105@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=hare@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox