From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 5/5] megasas: LSI Megaraid SAS emulation
Date: Tue, 05 Jul 2011 15:59:57 +0200
Message-ID: <4E1318DD.10703@redhat.com>
References: <1309863815-28236-1-git-send-email-hare@suse.de> <1309863815-28236-2-git-send-email-hare@suse.de> <1309863815-28236-3-git-send-email-hare@suse.de> <1309863815-28236-4-git-send-email-hare@suse.de> <1309863815-28236-5-git-send-email-hare@suse.de> <1309863815-28236-6-git-send-email-hare@suse.de> <4E1313E2.30400@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Hannes Reinecke <hare@suse.de>, qemu-devel@nongnu.org,
	Stefan Haynoczi <stefanha@linux.vnet.ibm.com>,
	kvm@vger.kernel.org
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:27467 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751969Ab1GEOAI (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 5 Jul 2011 10:00:08 -0400
In-Reply-To: <4E1313E2.30400@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/05/2011 03:38 PM, Alexander Graf wrote:
>>
>> +        if (is_sgl64) {
>> +            iov_pa = ldq_phys(pa);
>> +        } else {
>> +            iov_pa = ldl_phys(pa);
> 
> These load data from memory in target endianness. Are you sure that's 
> what you want? I'd expect this to be defined as little endian 
> (especially given that ldq and ldl on the same address work).

Seems to be target endianness from the corresponding Linux code:

        if (sge_count) {
                scsi_for_each_sg(scp, os_sgl, sge_count, i) {
                        mfi_sgl->sge32[i].length = sg_dma_len(os_sgl);
                        mfi_sgl->sge32[i].phys_addr = sg_dma_address(os_sgl);
                }
        }

...

        if (sge_count) {
                scsi_for_each_sg(scp, os_sgl, sge_count, i) {
                        mfi_sgl->sge64[i].length = sg_dma_len(os_sgl);
                        mfi_sgl->sge64[i].phys_addr = sg_dma_address(os_sgl);
                }
        }

Note that this is _either_ a ldq or a ldl depending on what the driver told
the device.  It is not accessing a 64-bit value as 32-bit.

Paolo