From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] ioeventfd: Introduce KVM_IOEVENTFD_FLAG_PIPE Date: Wed, 06 Jul 2011 14:30:51 +0300 Message-ID: <4E14476B.6010800@redhat.com> References: <1309712689-4290-1-git-send-email-levinsasha928@gmail.com> <4E10A3E6.1070606@redhat.com> <1309715091.4117.16.camel@sasha> <4E1195A1.10103@redhat.com> <1309790307.4117.25.camel@sasha> <4E11D20F.9020509@redhat.com> <1309791134.4117.27.camel@sasha> <4E11D540.6020003@redhat.com> <1309927073.2222.6.camel@sasha> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Ingo Molnar , Marcelo Tosatti , "Michael S. Tsirkin" , Pekka Enberg To: Sasha Levin Return-path: Received: from mx1.redhat.com ([209.132.183.28]:12633 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005Ab1GFLbL (ORCPT ); Wed, 6 Jul 2011 07:31:11 -0400 In-Reply-To: <1309927073.2222.6.camel@sasha> Sender: kvm-owner@vger.kernel.org List-ID: On 07/06/2011 07:37 AM, Sasha Levin wrote: > Instead of making these flags user configurable, they could be > implicitly defined according to the choice of eventfd or socket, I > couldn't decide which method was better so just went with the first one. > Explicit is better than implicit, so I agree with your choice here. -- error compiling committee.c: too many arguments to function