kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "Ren, Yongjie" <yongjie.ren@intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Glauber Costa <glommer@redhat.com>
Subject: Re: kvm upstream build error..
Date: Wed, 13 Jul 2011 16:18:52 +0300	[thread overview]
Message-ID: <4E1D9B3C.6090907@redhat.com> (raw)
In-Reply-To: <625BA99ED14B2D499DC4E29D8138F1506290C15CB3@shsmsx502.ccr.corp.intel.com>

On 07/13/2011 09:22 AM, Tian, Kevin wrote:
> it works in my side, due to config difference. It is caused by recent
> steal time feature.
>
> int kvm_set_msr_common(struct kvm_vcpu *vcpu, u32 msr, u64 data)
>          case MSR_KVM_STEAL_TIME:
>
>                  if (unlikely(!sched_info_on()))
>                          return 1;
>
> static inline int sched_info_on(void)
> {
> #ifdef CONFIG_SCHEDSTATS
>          return 1;
> #elif defined(CONFIG_TASK_DELAY_ACCT)
>          extern int delayacct_on;
>          return delayacct_on;
> #else
>          return 0;
> #endif
> }
>
> I have CONFIG_SCHEDSTATS enabled, while yours has CONFIG_SCHEDSTATS
> as 'n' while "CONFIG_TASK_DELAY_ACCT) as 'y'. However delayacct_on is
> not an exposed symbol to modules.
>

I added an export.  Thanks.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2011-07-13 13:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13  2:04 kvm upstream build error Ren, Yongjie
2011-07-13  6:22 ` Tian, Kevin
2011-07-13 13:18   ` Avi Kivity [this message]
2011-07-14  7:15     ` [PATCH] sched: export delayacct_on Ren, Yongjie
2011-07-14  9:55       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1D9B3C.6090907@redhat.com \
    --to=avi@redhat.com \
    --cc=glommer@redhat.com \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=yongjie.ren@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).