Re: [PATCH 5/5] ioeventfd: Introduce KVM_IOEVENTFD_FLAG_SOCKET

Avi Kivity
2011-07-14T08:28:30Z

On 07/14/2011 11:14 AM, Pekka Enberg wrote:
> >
> > I'm talking about the real world. Is any of this something that needs
> > optimization?
>
> Yes. See Sasha's other email. We should have mentioned that in the changelog.

It's completely unrealistic. Sash and you are the only two people in
the universe logging into the guest via a serial console and running
benchmarks.

> > 1024 vcpus logging in via the serial console at 10Gbps. Get real.
>
> [...]
>
> Huh, why are you bringing something like that up?

Because it's another example of an unrealistic approach on your part.
No real user is interested in 1024 vcpus, and no real user is interested
in optimized serial console. It's good that you are bringing up new
ideas and new code, but adding code just for its own sake is not a good
thing.

--
error compiling committee.c: too many arguments to function