From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 5/5] ioeventfd: Introduce KVM_IOEVENTFD_FLAG_SOCKET Date: Thu, 14 Jul 2011 16:23:07 +0300 Message-ID: <4E1EEDBB.10206@redhat.com> References: <1309927078-5983-1-git-send-email-levinsasha928@gmail.com> <4E1D442E.6090308@redhat.com> <4E1D9623.70801@redhat.com> <4E1D9E75.1070901@redhat.com> <4E1E9A3B.7090200@kernel.org> <4E1EA455.4010608@redhat.com> <4E1EA8A2.9020304@redhat.com> <4E1EBB7A.3030809@redhat.com> <4E1ED913.6070003@redh at.com> <1310646737.21171.23.camel@lappy> <4E1EE519.1020608@redhat.com> <1310648409.21171.34.camel@lappy> <4E1EE9A5.8040306@redhat.com> <1310649431.9498.28.camel@jaguar> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Sasha Levin , "Michael S. Tsirkin" , kvm@vger.kernel.org, Ingo Molnar , Marcelo Tosatti To: Pekka Enberg Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7295 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754770Ab1GNNXR (ORCPT ); Thu, 14 Jul 2011 09:23:17 -0400 In-Reply-To: <1310649431.9498.28.camel@jaguar> Sender: kvm-owner@vger.kernel.org List-ID: On 07/14/2011 04:17 PM, Pekka Enberg wrote: > > > > I still don't follow. The guest oopses? dmesg | less. An issue with > > tools/kvm? gdb -p `pgrep kvm`. > > When I was debugging tools/kvm virtio code, I used to 'instrument' the > guest kernel with printk() calls which helped a lot. > Sure, but do you really need it spewing out the serial port all the time? > Also, a bug in tools/kvm can manifest in many interesting ways in the > guest kernel during boot, for example. You can't do dmesg then and gdb > won't save you. I think you've lived too long in the table KVM and Qemu > land to remember how important reliable printk() is for development. I guess. Also I've switched to trace_printk() since it's much nicer (and intergrates with other ftrace features). And again, I'm not against tools/kvm optimizing serial. I just want better justification for socket-mmio. -- error compiling committee.c: too many arguments to function