From: Avi Kivity <avi@redhat.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: kvm@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Marcelo Tosatti <mtosatti@redhat.com>,
Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH v2 1/2] KVM: MMIO: Lock coalesced device when checking for available entry
Date: Mon, 18 Jul 2011 12:50:30 +0300 [thread overview]
Message-ID: <4E2401E6.8020200@redhat.com> (raw)
In-Reply-To: <1310981389.8209.3.camel@lappy>
On 07/18/2011 12:29 PM, Sasha Levin wrote:
> > Hmm. This means we take the lock for every I/O, whether it hits
> > coalesced mmio or not.
> >
> > We need to do the range check before taking the lock and the space check
> > after taking the lock.
> >
>
> I'll fix that.
>
> Shouldn't the range check be also locked somehow? Currently it is
> possible that a coalesced region was removed while we are checking the
> ranges, and we won't issue a mmio exit as the host expects
It's "locked" using rcu.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-07-18 9:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 11:37 [PATCH v2 1/2] KVM: MMIO: Lock coalesced device when checking for available entry Sasha Levin
2011-07-15 11:37 ` [PATCH v2 2/2] x86: Raise the hard VCPU count limit Sasha Levin
2011-07-21 9:24 ` Ingo Molnar
2011-07-18 8:11 ` [PATCH v2 1/2] KVM: MMIO: Lock coalesced device when checking for available entry Avi Kivity
2011-07-18 9:29 ` Sasha Levin
2011-07-18 9:50 ` Avi Kivity [this message]
2011-07-18 10:15 ` Sasha Levin
2011-07-18 11:43 ` Avi Kivity
2011-07-18 12:03 ` Sasha Levin
2011-07-18 12:29 ` Avi Kivity
2011-07-18 12:58 ` Sasha Levin
2011-07-18 13:11 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2401E6.8020200@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox