From: Avi Kivity <avi@redhat.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] MMIO: Make coalesced mmio use a device per zone
Date: Tue, 19 Jul 2011 11:48:51 +0300 [thread overview]
Message-ID: <4E2544F3.9030203@redhat.com> (raw)
In-Reply-To: <1311063011-4430-1-git-send-email-levinsasha928@gmail.com>
On 07/19/2011 11:10 AM, Sasha Levin wrote:
> This patch changes coalesced mmio to create one mmio device per
> zone instead of handling all zones in one device.
>
> Doing so enables us to take advantage of existing locking and prevents
> a race condition between coalesced mmio registration/unregistration
> and lookups.
>
>
>
> #include "coalesced_mmio.h"
>
> +static spinlock_t lock;
> +static LIST_HEAD(head);
Make these per-guest instead of global. The lock may be contended, and
the list shouldn't hold items from different guests (why is it needed,
anyway?)
The coalesced mmio devices will now contend with other io devices for
NR_IOBUS_DEVS, so need to increase that (by KVM_COALESCED_MMIO_ZONE_MAX).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-07-19 8:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 8:10 [PATCH] MMIO: Make coalesced mmio use a device per zone Sasha Levin
2011-07-19 8:48 ` Avi Kivity [this message]
2011-07-19 9:53 ` Sasha Levin
2011-07-19 9:59 ` Avi Kivity
2011-07-19 10:17 ` Sasha Levin
2011-07-19 10:32 ` Avi Kivity
2011-07-19 11:22 ` Sasha Levin
2011-07-19 11:45 ` Sasha Levin
2011-07-19 17:14 ` Jan Kiszka
2011-07-19 17:17 ` Avi Kivity
2011-07-19 17:23 ` Jan Kiszka
2011-07-19 19:28 ` Sasha Levin
2011-07-19 20:00 ` Jan Kiszka
2011-07-20 8:24 ` Avi Kivity
2011-07-20 8:43 ` Jan Kiszka
2011-07-20 8:52 ` Avi Kivity
2011-07-20 8:55 ` Jan Kiszka
2011-07-20 8:58 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2544F3.9030203@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox