From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] MMIO: Make coalesced mmio use a device per zone Date: Tue, 19 Jul 2011 12:59:32 +0300 Message-ID: <4E255584.1030003@redhat.com> References: <1311063011-4430-1-git-send-email-levinsasha928@gmail.com> <4E2544F3.9030203@redhat.com> <1311069182.9174.1.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti To: Sasha Levin Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52635 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751431Ab1GSJ7h (ORCPT ); Tue, 19 Jul 2011 05:59:37 -0400 In-Reply-To: <1311069182.9174.1.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: On 07/19/2011 12:53 PM, Sasha Levin wrote: > > Make these per-guest instead of global. The lock may be contended, and > > the list shouldn't hold items from different guests (why is it needed, > > anyway?) > > > > We only need the list for removal, since we only have the range we want > to remove, and we want to find all devices which contain this range. > All devices in the same guest which contain this range. Your patch removes devices from all guests. -- error compiling committee.c: too many arguments to function