From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/3] qemu-x86: Add tsc_freq option to -cpu
Date: Tue, 19 Jul 2011 15:20:37 +0300 [thread overview]
Message-ID: <4E257695.4010906@redhat.com> (raw)
In-Reply-To: <20110719114658.GA28500@amt.cnet>
On 07/19/2011 02:46 PM, Marcelo Tosatti wrote:
> On Thu, Jul 07, 2011 at 04:13:12PM +0200, Joerg Roedel wrote:
> > To let the user configure the desired tsc frequency for the
> > guest if running in KVM.
> >
> > Signed-off-by: Joerg Roedel<joerg.roedel@amd.com>
> > ---
> > target-i386/cpu.h | 1 +
> > target-i386/cpuid.c | 13 +++++++++++++
> > 2 files changed, 14 insertions(+), 0 deletions(-)
> >
> > diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> > index cdf68ff..399e124 100644
> > --- a/target-i386/cpu.h
> > +++ b/target-i386/cpu.h
> > @@ -743,6 +743,7 @@ typedef struct CPUX86State {
> > uint32_t cpuid_kvm_features;
> > uint32_t cpuid_svm_features;
> > bool tsc_valid;
> > + int tsc_khz;
>
> This should be saved/restore in migration data (missing VMSTATE entry).
Why? It's static data. Traditionally we only migrate runtime data.
(although we've been talking about starting a naked qemu and pushing all
of the configuration from the source).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-07-19 12:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 14:13 [PATCH 0/3][uq/master] Basic TSC-Scaling support v2 Joerg Roedel
2011-07-07 14:13 ` [PATCH 1/3] qemu: Add strtosz_suffix_unit function Joerg Roedel
2011-07-08 8:00 ` Markus Armbruster
2011-07-07 14:13 ` [PATCH 2/3] qemu-x86: Add tsc_freq option to -cpu Joerg Roedel
2011-07-19 11:46 ` Marcelo Tosatti
2011-07-19 12:20 ` Avi Kivity [this message]
2011-07-19 12:56 ` Marcelo Tosatti
2011-07-19 13:30 ` Joerg Roedel
2011-07-19 13:54 ` Avi Kivity
2011-07-19 13:55 ` Avi Kivity
2011-07-19 14:14 ` Joerg Roedel
2011-07-19 15:55 ` Avi Kivity
2011-07-07 14:13 ` [PATCH 3/3] qemu-x86: Set tsc_khz in kvm when supported Joerg Roedel
2011-07-19 11:48 ` Marcelo Tosatti
2011-07-19 17:03 ` Jan Kiszka
2011-07-19 13:04 ` [PATCH 0/3][uq/master] Basic TSC-Scaling support v2 Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E257695.4010906@redhat.com \
--to=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox