From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2] MMIO: Make coalesced mmio use a device per zone Date: Tue, 19 Jul 2011 15:39:59 +0300 Message-ID: <4E257B1F.1090706@redhat.com> References: <1311071471-15546-1-git-send-email-levinsasha928@gmail.com> <4E256301.1040700@redhat.com> <1311073516.9174.10.camel@lappy> <4E25777F.1060604@redhat.com> <1311078878.20113.2.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti To: Sasha Levin Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46343 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751265Ab1GSMkE (ORCPT ); Tue, 19 Jul 2011 08:40:04 -0400 In-Reply-To: <1311078878.20113.2.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: On 07/19/2011 03:34 PM, Sasha Levin wrote: > > > > btw, don't we leak all zones on guest destruction? the array didn't need > > any cleanup, but this list does. > > > > No, the destructor is called for all devices on the bus when the bus is > going down. We're handling it in coalesced_mmio_destructor() which frees > the device. Ah, okay. A somewhat strange setup. -- error compiling committee.c: too many arguments to function