From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC v4 00/58] Memory API Date: Tue, 19 Jul 2011 16:57:15 +0300 Message-ID: <4E258D3B.5050103@redhat.com> References: <1310901265-32051-1-git-send-email-avi@redhat.com> <20110719135601.GA7194@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:64037 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024Ab1GSN5U (ORCPT ); Tue, 19 Jul 2011 09:57:20 -0400 In-Reply-To: <20110719135601.GA7194@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/19/2011 04:56 PM, Michael S. Tsirkin wrote: > On Sun, Jul 17, 2011 at 02:13:27PM +0300, Avi Kivity wrote: > > New in this version: > > MemoryRegionOps gained .old_mmio and .old_portio members, which allow > > reusing old-style callbacks with the new API. All uses were converted, > > except for eepro100.c, which uses the same MemoryRegionOps for both > > portio and mmio. Some intermediate patches do introduce dispatching > > callbacks, but they are removed later. > > > > Caveats: > > - some devices still grab a global memory region instead of inheriting > > it from their bus. Seen in the code as #include "exec-memory.h" > > Looks good to me. > > It looks like with this, users of vga_dirty_log_stop > like qxl_write_config can go away because the region can > stay registered with dirty logging enabled? Yes. You set the property once on the framebuffer, and it and all aliases are tracked whenever they or a subregion are exposed. -- error compiling committee.c: too many arguments to function