From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC v4 00/58] Memory API Date: Tue, 19 Jul 2011 20:14:34 +0300 Message-ID: <4E25BB7A.7030105@redhat.com> References: <1310901265-32051-1-git-send-email-avi@redhat.com> <20110719135601.GA7194@redhat.com> <4E25B85C.1030809@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:21717 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712Ab1GSROo (ORCPT ); Tue, 19 Jul 2011 13:14:44 -0400 In-Reply-To: <4E25B85C.1030809@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/19/2011 08:01 PM, Jan Kiszka wrote: > On 2011-07-19 15:56, Michael S. Tsirkin wrote: > > On Sun, Jul 17, 2011 at 02:13:27PM +0300, Avi Kivity wrote: > >> New in this version: > >> MemoryRegionOps gained .old_mmio and .old_portio members, which allow > >> reusing old-style callbacks with the new API. All uses were converted, > >> except for eepro100.c, which uses the same MemoryRegionOps for both > >> portio and mmio. Some intermediate patches do introduce dispatching > >> callbacks, but they are removed later. > >> > >> Caveats: > >> - some devices still grab a global memory region instead of inheriting > >> it from their bus. Seen in the code as #include "exec-memory.h" > > > > Looks good to me. > > > > It looks like with this, users of vga_dirty_log_stop > > like qxl_write_config can go away because the region can > > stay registered with dirty logging enabled? > > That was already possible with the old API, see [1]. Makes me wonder > what will be merged first... > Rebasing is already not so fun for me with 78 patches and counting. Let's drop yours and focus of getting mine in shape, since it's a superset. If anybody wants to help in the mostly mechanical conversions, let me a note. It's usually simple, easy, and boring, but there are surprises. -- error compiling committee.c: too many arguments to function