From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [RFC v4 00/58] Memory API Date: Tue, 19 Jul 2011 19:30:14 +0200 Message-ID: <4E25BF26.6080900@siemens.com> References: <1310901265-32051-1-git-send-email-avi@redhat.com> <20110719135601.GA7194@redhat.com> <4E25B85C.1030809@siemens.com> <4E25BB7A.7030105@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" To: Avi Kivity Return-path: Received: from david.siemens.de ([192.35.17.14]:26698 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133Ab1GSRaW (ORCPT ); Tue, 19 Jul 2011 13:30:22 -0400 In-Reply-To: <4E25BB7A.7030105@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-07-19 19:14, Avi Kivity wrote: > On 07/19/2011 08:01 PM, Jan Kiszka wrote: >> On 2011-07-19 15:56, Michael S. Tsirkin wrote: >>> On Sun, Jul 17, 2011 at 02:13:27PM +0300, Avi Kivity wrote: >>>> New in this version: >>>> MemoryRegionOps gained .old_mmio and .old_portio members, which allow >>>> reusing old-style callbacks with the new API. All uses were converted, >>>> except for eepro100.c, which uses the same MemoryRegionOps for both >>>> portio and mmio. Some intermediate patches do introduce dispatching >>>> callbacks, but they are removed later. >>>> >>>> Caveats: >>>> - some devices still grab a global memory region instead of inheriting >>>> it from their bus. Seen in the code as #include "exec-memory.h" >>> >>> Looks good to me. >>> >>> It looks like with this, users of vga_dirty_log_stop >>> like qxl_write_config can go away because the region can >>> stay registered with dirty logging enabled? >> >> That was already possible with the old API, see [1]. Makes me wonder >> what will be merged first... >> > > Rebasing is already not so fun for me with 78 patches and counting. > Let's drop yours and focus of getting mine in shape, since it's a superset. The patches series are widely orthogonal except for both killing the obsolete start/stop logging logic. But I don't mind rebasing over yours - if something is finally merged at all. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux