From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: Sasha Levin <levinsasha928@gmail.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] MMIO: Make coalesced mmio use a device per zone
Date: Wed, 20 Jul 2011 10:43:55 +0200 [thread overview]
Message-ID: <4E26954B.6000606@siemens.com> (raw)
In-Reply-To: <4E2690B5.9050206@redhat.com>
On 2011-07-20 10:24, Avi Kivity wrote:
> On 07/19/2011 08:23 PM, Jan Kiszka wrote:
>> On 2011-07-19 19:17, Avi Kivity wrote:
>>> On 07/19/2011 08:14 PM, Jan Kiszka wrote:
>>>>
>>>> Another improvement - unfortunately less transparent for user space -
>>>> would be to overcome the single ring buffer that forces us to hold a
>>>> central lock in user space while processing the entries. We rather need
>>>> per-device rings. While waiting for coalesced VGA MMIO being processed,
>>>> way too many kittens are killed.
>>>>
>>>> I have this on our agenda, but I wouldn't be disappointed as well if
>>>> someone else is faster.
>>>
>>> The socket mmio would have accomplished this as well.
>>
>> I haven't followed the outcome in all details - is that approach dead
>> due to its complexity?
>>
>>> One thing to
>>> beware of is to preserve correctness:
>>>
>>> 1) write to 0xa0000 (queued)
>>> 2) write to 0xa0002 (queued)
>>> 3) remap 0xa0000 region (executed)
>>
>> Obviously, there must be 3a) here: drain all affected queues.
>
> How do you implement this 3a, if your consumers are outside the main
> process? I guess you could have an additional synchonize API (for
> in-kernel consumers) or RPC (for external process consumers), but then
> this is no longer a simple API.
I'm not planning to leave the hypervisor process for now, not to speak
of in-kernel models. Already for many other reasons, a synchronization
API between a hypothetical decoupled device model and the core will be
quite complex. The first step is to get it scalable using a single process.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-07-20 8:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 8:10 [PATCH] MMIO: Make coalesced mmio use a device per zone Sasha Levin
2011-07-19 8:48 ` Avi Kivity
2011-07-19 9:53 ` Sasha Levin
2011-07-19 9:59 ` Avi Kivity
2011-07-19 10:17 ` Sasha Levin
2011-07-19 10:32 ` Avi Kivity
2011-07-19 11:22 ` Sasha Levin
2011-07-19 11:45 ` Sasha Levin
2011-07-19 17:14 ` Jan Kiszka
2011-07-19 17:17 ` Avi Kivity
2011-07-19 17:23 ` Jan Kiszka
2011-07-19 19:28 ` Sasha Levin
2011-07-19 20:00 ` Jan Kiszka
2011-07-20 8:24 ` Avi Kivity
2011-07-20 8:43 ` Jan Kiszka [this message]
2011-07-20 8:52 ` Avi Kivity
2011-07-20 8:55 ` Jan Kiszka
2011-07-20 8:58 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E26954B.6000606@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox