From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [RFC v4 00/58] Memory API Date: Wed, 20 Jul 2011 15:57:32 +0200 Message-ID: <4E26DECC.9000700@siemens.com> References: <1310901265-32051-1-git-send-email-avi@redhat.com> <20110719135601.GA7194@redhat.com> <4E25B85C.1030809@siemens.com> <4E25BB7A.7030105@redhat.com> <4E25BF26.6080900@siemens.com> <4E268E20.5050807@redhat.com> <4E26BF77.7070705@siemens.com> <4E26C290.8010604@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" To: Avi Kivity Return-path: Received: from goliath.siemens.de ([192.35.17.28]:15897 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602Ab1GTN5k (ORCPT ); Wed, 20 Jul 2011 09:57:40 -0400 In-Reply-To: <4E26C290.8010604@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-07-20 13:57, Avi Kivity wrote: > On 07/20/2011 02:43 PM, Jan Kiszka wrote: >> On 2011-07-20 10:13, Avi Kivity wrote: >>> On 07/19/2011 08:30 PM, Jan Kiszka wrote: >>>>> Rebasing is already not so fun for me with 78 patches and counting. >>>>> Let's drop yours and focus of getting mine in shape, since it's a superset. >>>> >>>> The patches series are widely orthogonal except for both killing the >>>> obsolete start/stop logging logic. >>>> >>>> But I don't mind rebasing over yours - if something is finally merged at >>>> all. >>> >>> If you post patches I'll incorporate them in my patchset. They're >>> available in qemu-kvm.git branch memory-region. >> >> Is that branch up-to-date? It spits out tons of debug messages, making >> it unusable for any test. >> > > I usually redirect them away. > > I'll move the two patches on top, so it's easy to have git drop them. Something around dirty logging is still seriously borken: when I boot with standard or cirrus vga, the screen is not properly updated in logged modes. I bet the reason is lacking semantics of cpu_register_physical_memory_log(..., true), ie. the chance to register a memory region with logging enabled. We need to explicitly enable it now via memory_region_set_log, right? Is there any ordering issue to expect, ie. when can I first call memory_region_set_log (as it issues the start/stop client callbacks)? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux