From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [RFC v4 23/58] vga: convert vga and its derivatives to the memory API Date: Wed, 20 Jul 2011 16:52:15 +0200 Message-ID: <4E26EB9F.10802@siemens.com> References: <1310901265-32051-1-git-send-email-avi@redhat.com> <1310901265-32051-24-git-send-email-avi@redhat.com> <4E26E0AF.9040503@siemens.com> <4E26E8CF.2080205@redhat.com> <4E26EA0F.40302@siemens.com> <4E26EAB3.7010708@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" To: Avi Kivity Return-path: Received: from david.siemens.de ([192.35.17.14]:24167 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751440Ab1GTOwX (ORCPT ); Wed, 20 Jul 2011 10:52:23 -0400 In-Reply-To: <4E26EAB3.7010708@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-07-20 16:48, Avi Kivity wrote: > On 07/20/2011 05:45 PM, Jan Kiszka wrote: >>> >>> (that's the whole point - it can be made invisible by something outside >>> the cirrus card's knowledge). >>> >>> Note - with kvm, there is still a race between syncing the bitmap and >>> removing the region. However that is a bug in the kvm API; it is not >>> possible to work around it in qemu. >>> >> >> Dirty log off, reconfigure, dirty log on? > > What happens if there's a write after the first comma (assuming > "reconfigure" == "remove slot")? > > Granted, the guest shouldn't be doing that. > > Hmm, I guess you could just mark the entire range dirty after removing it. Maybe. So the problem is that the dirty bitmap is lost when we unregister a region with the KVM kernel? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux