From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC v4 00/58] Memory API Date: Wed, 20 Jul 2011 17:54:26 +0300 Message-ID: <4E26EC22.1030309@redhat.com> References: <1310901265-32051-1-git-send-email-avi@redhat.com> <20110719135601.GA7194@redhat.com> <4E25B85C.1030809@siemens.com> <4E25BB7A.7030105@redhat.com> <4E25BF26.6080900@siemens.com> <4E268E20.5050807@redhat.com> <4E26BF77.7070705@siemens.com> <4E26C290.8010604@redhat.com> <4E26DECC.9000700@siemens.com> <4E26E716.2090109@redhat.com> <20110720143720.GC6787@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:8819 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317Ab1GTOye (ORCPT ); Wed, 20 Jul 2011 10:54:34 -0400 In-Reply-To: <20110720143720.GC6787@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/20/2011 05:37 PM, Michael S. Tsirkin wrote: > > > > If you do a memory_region_set_log() immediately after > > memory_region_init_ram(), then as soon as the framebuffer is added > > to the memory hierarchy, it will have logging enabled (or any > > aliases of the framebuffer). > > Still, I think we should specify logging on/off when region is created, > and avoid APIs that tweak dirty logging. It's the same thing. memory_region_init*(); // we have a disconnected memory region memory_region_set_log(); // still disconnected, now logged I don't want memory_region_init() with 231 parameters. > I don't think there's actual need for device to enable/disable > logging. Why not? migration does it, and vga could do it if the vnc display is disconnected, or if the update rate is so high it can just assume all memory is dirty. > What devices seem to need, instead, is enable/disable a region > through a back channel. What do you mean? -- error compiling committee.c: too many arguments to function