From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [RFC v4 11/58] memory: add ioeventfd support
Date: Wed, 20 Jul 2011 20:31:34 +0300
Message-ID: <4E2710F6.6070909@redhat.com>
References: <1310901265-32051-1-git-send-email-avi@redhat.com> <1310901265-32051-12-git-send-email-avi@redhat.com> <CAAu8pHsj4uOdg6hbe8SHRfu2rhmgdAextoqfm63SuHEXJLCmeA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Blue Swirl <blauwirbel@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:36651 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751879Ab1GTRbm (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 20 Jul 2011 13:31:42 -0400
In-Reply-To: <CAAu8pHsj4uOdg6hbe8SHRfu2rhmgdAextoqfm63SuHEXJLCmeA@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/20/2011 08:29 PM, Blue Swirl wrote:
> >  +
> >  +static bool memory_region_ioeventfd_before(MemoryRegionIoeventfd a,
> >  +                                           MemoryRegionIoeventfd b)
> >  +{
> >  +    if (a.addr.start<  b.addr.start) return true;
> >  +    if (a.addr.start>  b.addr.start) return false;
> >  +    if (a.addr.size<  b.addr.size) return true;
> >  +    if (a.addr.size>  b.addr.size) return false;
> >  +    if (a.match_data<  b.match_data) return true;
> >  +    if (a.match_data>  b.match_data) return false;
> >  +    if (a.match_data) {
> >  +        if (a.data<  b.data) return true;
> >  +        if (a.data>  b.data) return false;
> >  +    }
> >  +    if (a.fd<  b.fd) return true;
> >  +    if (a.fd>  b.fd) return false;
>
> NACK for CODING_STYLE.

Just checking if you're awake.

Will fix.

-- 
error compiling committee.c: too many arguments to function