Re: [RFC v5 00/86] Memory API

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2011-07-20 18:49, Avi Kivity wrote:
> New in this version:
>   - more mindless conversions; I believe there are no longer any destructive
>     operations in the tree (IO_MEM_UNASSIGNED)
>   - fix memory map generation bug (patch 13)
>   - proper 440FX PAM/SMRAM and PCI holes
> 

This on top fixes standard VGA dirty logging:

diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index e367052..8e8b24c 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -2944,8 +2944,6 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev)
     memory_region_add_subregion(&s->pci_bar, 0x1000000,
                                 &s->cirrus_linear_bitblt_io);
 
-    vga_dirty_log_start(&s->vga);
-
      /* setup memory space */
      /* memory #0 LFB */
      /* memory #1 memory-mapped I/O */
diff --git a/hw/vga.c b/hw/vga.c
index 5a78b71..8acc545 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -2195,6 +2195,7 @@ void vga_common_init(VGACommonState *s, int vga_ram_size)
         s->update_retrace_info = vga_precise_update_retrace_info;
         break;
     }
+    vga_dirty_log_start(s);
 }
 
 /* used by both ISA and PCI */

Cirrus is still broken (test case: grub), debugging ATM.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux