Re: [PATCH] memory: transaction API

[Avi Kivity <avi@redhat.com>]

On 07/21/2011 03:05 PM, Avi Kivity wrote:
> On 07/21/2011 01:38 PM, Jan Kiszka wrote:
>> On 2011-07-21 12:21, Avi Kivity wrote:
>> >  Allow changes to the memory hierarchy to be accumulated and
>> >  made visible all at once.  This reduces computational effort,
>> >  especially when an accelerator (e.g. kvm) is involved.
>> >
>> >  Useful when a single register update causes multiple changes
>> >  to an address space.
>>
>> That's simple to implement in the core, but complicates life for the
>> users, at least for the simple "update this region" use case.
>>
>
> Why? just stick a _begin() and _commit() at the start and end of the 
> update_mapping() function.  It's an optional API, for simple cases 
> (like mapping a BAR) you don't have to use it.
>

Do you see an improvement if you change cirrus_update_memory_access() in 
this fashion?

-- 
error compiling committee.c: too many arguments to function