From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] memory: transaction API Date: Thu, 21 Jul 2011 15:58:46 +0300 Message-ID: <4E282286.2050508@redhat.com> References: <1311243679-18403-1-git-send-email-avi@redhat.com> <4E280195.5040003@siemens.com> <4E281609.7090809@redhat.com> <4E2816DE.5010102@siemens.com> <4E2817DA.4030505@redhat.com> <4E28211C.5060705@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26367 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751888Ab1GUM6x (ORCPT ); Thu, 21 Jul 2011 08:58:53 -0400 In-Reply-To: <4E28211C.5060705@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/21/2011 03:52 PM, Jan Kiszka wrote: > > > > The problem is that "update" can change lots of things. offset, size, > > whether it's mmio or RAM, read-onlyness, even the wierd things like > > coalesced mmio. So it's either a function with 324.2 parameters (or a > > large struct), or it's a series of functions with demarcation as to > > where the update begins and ends. > > We do not need to provide update support for each and every bit, but for > the common cases. memory_region_update_alias(region, offset, size) would > be an excellent first candidate IMO. It's not enough, look at cirrus and PAM. -- error compiling committee.c: too many arguments to function