From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] cpu hotplug issue Date: Thu, 21 Jul 2011 16:15:09 +0300 Message-ID: <4E28265D.5050807@redhat.com> References: <20110720083507.GS2400@redhat.com> <20110721113342.GB3044@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , jan.kiszka@siemens.com, kvm@vger.kernel.org To: Vasilis Liaskovitis Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1359 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752868Ab1GUNPQ (ORCPT ); Thu, 21 Jul 2011 09:15:16 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 07/21/2011 04:08 PM, Vasilis Liaskovitis wrote: > Hi, > > thanks for looking at this closer. > > On Thu, Jul 21, 2011 at 1:33 PM, Gleb Natapov wrote: > > >> Note that there is probably another bug in qemu-kvm/master regarding > >> acpi-udev event delivery for > >> a cpu-hotplug event (cpu_set in the qemu_monitor no longer triggers > >> the event in the guest, see > >> first issue in my original mail). This patch does not address that issue. > >> > > Did this work in qemu-0.13? > > yes, the acpi-event delivery worked fine for me in 0.13.0 > > I also tried to separately bisect the acpi-udev delivery issue between > 0.13.0 and qemu-kvm/master but ended up > with a big merge commit as the culprit. Not sure if it would help. You can bisect it further. If you tag the bad commit "bad", then you do $ git bisect start bad^2 $(git merge-base bad^1 bad^2) (for each commit bisect feeds you:) $ git merge --no-commit bad^1 $ git checkout -f $ git bisect What this does is bisect all commits added by the merge, but first re-does the merge before testing. You shouldn't have any conflicts during these merging. It is recommended to set up ccache to reduce build time, as those merges force a full rebuild every time. -- error compiling committee.c: too many arguments to function