Re: [PATCH] memory: transaction API

Avi Kivity
2011-07-21T12:58:53Z

On 07/21/2011 03:52 PM, Jan Kiszka wrote:
> >
> > The problem is that "update" can change lots of things. offset, size,
> > whether it's mmio or RAM, read-onlyness, even the wierd things like
> > coalesced mmio. So it's either a function with 324.2 parameters (or a
> > large struct), or it's a series of functions with demarcation as to
> > where the update begins and ends.
>
> We do not need to provide update support for each and every bit, but for
> the common cases. memory_region_update_alias(region, offset, size) would
> be an excellent first candidate IMO.

It's not enough, look at cirrus and PAM.

--
error compiling committee.c: too many arguments to function