From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/3] perf: add context field to perf_event Date: Thu, 21 Jul 2011 18:59:00 +0300 Message-ID: <4E284CC4.8060902@redhat.com> References: <4E1BF5A1.5070301@redhat.com> <1310459898.18678.108.camel@twins> <4E1C0F02.9040906@redhat.com> <1310462046.14978.11.camel@twins> <4E1C10F8.6010300@redhat.com> <1310462335.14978.12.camel@twins> <4E1C1373.5080500@redhat.com> <1310463060.14978.17.camel@twins> <20110721153238.GC8446@e102144-lin.cambridge.arm.com> <4E28478B.1070907@redhat.com> <20110721154648.GD8446@e102144-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Peter Zijlstra , Frederic Weisbecker , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , Ingo Molnar , "acme@ghostprotocols.net" , Jason Wessel To: Will Deacon Return-path: In-Reply-To: <20110721154648.GD8446@e102144-lin.cambridge.arm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/21/2011 06:46 PM, Will Deacon wrote: > > > > This is (and must be) called from a preempt disabled context, no mutexes > > around here. > > Bah, yes, that is essential if you're dealing with current. Maybe use a > spinlock instead? Could work. Not thrilled about adding it to the kvm hot path, but I can't say it will make a measurable impact. -- error compiling committee.c: too many arguments to function